Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2151] Allow github actions OIDC authentication to AKS clusters #140

Merged
merged 1 commit into from
Dec 31, 2024

Conversation

saliceti
Copy link
Member

@saliceti saliceti commented Dec 19, 2024

Context

Update kubelogin arguments to use OIDC instead of service principal secret

Changes proposed in this pull request

Update kubelogin arguments

Guidance to review

See DFE-Digital/itt-mentor-services#1253

After merging

Update DFE-Digital/itt-mentor-services#1253 to point at main

Checklist

  • I have performed a self-review of my code, including formatting and typos
  • I have cleaned the commit history
  • I have added the Devops label
  • I have attached the pull request to the trello card

Copy link
Contributor

@vipin-dfe vipin-dfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Required for configuring the kubernetes provider when running in a
workflow where OIDC is enabled
@saliceti saliceti merged commit 040b9e9 into main Dec 31, 2024
3 checks passed
@saliceti saliceti deleted the oidc-ga branch December 31, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants